[6.x] Fix single-mode date fieldtype crashing when saving with a time#14880
Open
mynetx wants to merge 1 commit into
Open
[6.x] Fix single-mode date fieldtype crashing when saving with a time#14880mynetx wants to merge 1 commit into
mynetx wants to merge 1 commit into
Conversation
The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving an entry with a single-mode
datefield whose format includes a time throws aTypeError. The CP submits the value as a['date' => ..., 'time' => ...]array, butprocessSingle()passed it straight toCarbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makesformatHasTime()true regardless oftime_enabled.This combines the date and time into a single string before parsing.
Fixes #14860