test: migrate stats/base/dists/bernoulli/mean to ULP-base assertions - #14832
Merged
Conversation
Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352 .
Description
This pull request:
test/test.jsandtest/test.native.jsofstats/base/dists/bernoulli/meanfrom relative-tolerance (EPS-based) assertions to ULP-difference assertions via@stdlib/assert/is-almost-same-value.if ( y === expected[i] ) {...} else { delta = abs(...); tol = 1.0*EPS*abs(...); t.ok( delta <= tol, ... ) }branch witht.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ).absandEPSrequires.1by measuring the actual ULP difference betweenmean()output and the fixture-expected values across all 1000 fixtures; the maximum observed difference was within 1 ULP (the implementation is a simple identity computation returningp, which reproduces the Julia fixture values), so the ULP bound is set to1. This mirrors the existing convention used for other simple-formula distribution functions in this codebase. The full suite (1007 assertions per implementation) was run to confirm deterministic results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers