Skip to content

test: migrate blas/base/drotm to ULP-based assertions - #14869

Merged
kgryte merged 1 commit into
developfrom
philipp/ulp-blas-base-drotm
Sep 1, 2026
Merged

test: migrate blas/base/drotm to ULP-based assertions#14869
kgryte merged 1 commit into
developfrom
philipp/ulp-blas-base-drotm

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Sep 1, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the blas/base/drotm test suite (test.drotm.js, test.drotm.native.js, test.ndarray.js, test.ndarray.native.js) from the relative-tolerance isApprox idiom (EPS/abs-based) to @stdlib/assert/is-almost-same-value-based ULP difference assertions.
  • determines the tightest ULP bound per test body by computing the exact ULP difference (via @stdlib/number/float64/base/ulp-difference) between the actual and expected values produced by both the JavaScript and native (C) implementations, and confirmed the result is deterministic across repeated runs.
  • final ULP constants used (identical across the JS and native/ndarray variants, since both implementations produced identical results down to the ULP):
    • sx=1, sy=1: ULP = 2
    • sx=2, sy=-2: ULP = 1
    • sx=-2, sy=1: ULP = 2
    • sx=-1, sy=-2 / sx=-1, sy=-2 (test.ndarray.js naming): ULP = 1
    • applies a plane rotation, x/y stride, x/y offset (ndarray only), negative x/y stride: ULP = 0 (exact match)
    • supports complex access patterns: ULP = 1

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Only the test files in blas/base/drotm/test/ were changed; no package.json changes were needed. make test (via npx tape) passes for all four test files (416/416, 416/416, 440/440, 440/440), run twice to confirm determinism, and npx eslint reports no new lint errors introduced by this change (pre-existing bracket-spacing lint debt in these files is unrelated and untouched).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, including computing the tightest ULP bounds and applying the test-file edits.

@stdlib-js/reviewers

Generated by Claude Code
@claude
test: migrate blas/base/drotm to ULP-based assertions
fb408fe 
Replaces the relative-tolerance comparisons in the blas/base/drotm test suite with @stdlib/assert/is-almost-same-value and a tightened, named ULP constant per test body.

Ref: #11352

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue. labels Sep 1, 2026
@stdlib-bot

stdlib-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!
@stdlib-bot

stdlib-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/drotm $\\color{green}469/469$
$\\color{green}+100.00\\%$ 		$\\color{green}35/35$
$\\color{green}+100.00\\%$ 		$\\color{green}4/4$
$\\color{green}+100.00\\%$ 		$\\color{green}469/469$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.
@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 1, 2026
@kgryte
kgryte marked this pull request as ready for review September 1, 2026 10:16
@kgryte
kgryte requested a review from a team September 1, 2026 10:16
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 1, 2026
@kgryte
kgryte merged commit 9c211bd into develop Sep 1, 2026
82 checks passed
@kgryte
kgryte deleted the philipp/ulp-blas-base-drotm branch September 1, 2026 10:20
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue. Tests Pull requests specifically adding tests.

4 participants

@Planeshifter @stdlib-bot @kgryte @claude