Skip to content

fix(contacts): correct parameter types in contacts apply helpers#355

Open
laihenyi wants to merge 2 commits intosteipete:mainfrom
laihenyi:fix/contacts-param-types
Open

fix(contacts): correct parameter types in contacts apply helpers#355
laihenyi wants to merge 2 commits intosteipete:mainfrom
laihenyi:fix/contacts-param-types

Conversation

@laihenyi
Copy link
Contributor

@laihenyi laihenyi commented Feb 23, 2026

Summary

  • Fix build error in contactsApplyPersonName and contactsApplyPersonOrganization where Go's parameter grouping syntax caused given and org to be typed as bool instead of string
  • e.g. givenSet bool, given, familySet bool groups given and familySet as bool, but given should be string

Test plan

  • make builds successfully
  • make test all tests pass

🤖 Generated with Claude Code
laihenyi and others added 2 commits February 23, 2026 12:38
@laihenyi @claude
fix(contacts): correct parameter types in contacts apply helpers
30ebfb5 
Go's parameter grouping syntax caused `given` and `org` to be typed as
`bool` instead of `string` in contactsApplyPersonName and
contactsApplyPersonOrganization, resulting in a build failure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@laihenyi @claude
fix(contacts): resolve lint errors from upstream refactor
c3dbaf9 
- Rewrite if-else chain to switch statement (gocritic)
- Rename `clear` variable to `clearAll` to avoid shadowing predeclared
  identifier (predeclared)
- Remove unused `primaryURL` function (unused)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@laihenyi