Skip to content

fix(contacts): correct parameter types in contactsApplyPersonName and contactsApplyPersonOrganization#372

Open
RoggeOhta wants to merge 1 commit intosteipete:mainfrom
RoggeOhta:fix/contacts-crud-param-types
Open

fix(contacts): correct parameter types in contactsApplyPersonName and contactsApplyPersonOrganization#372
RoggeOhta wants to merge 1 commit intosteipete:mainfrom
RoggeOhta:fix/contacts-crud-param-types

Conversation

@RoggeOhta
Copy link

@RoggeOhta RoggeOhta commented Feb 26, 2026

Summary

Fixes #371

  • contactsApplyPersonName: given, familySet bool → given string, familySet bool
  • contactsApplyPersonOrganization: org, titleSet bool → org string, titleSet bool

Go's grouped parameter shorthand a, b Type declares both as Type. The given and org parameters were intended to be string, not bool, causing a compile failure on main.

Test plan

  • make build compiles successfully
  • ./bin/gog --version runs correctly
@RoggeOhta
fix(contacts): correct parameter types in contactsApplyPersonName and…
216b3ef 
… contactsApplyPersonOrganization

The grouped parameter declarations `given, familySet bool` and
`org, titleSet bool` caused Go to treat both identifiers as bool,
making the project fail to compile. Separate the string and bool
parameters with explicit types to fix the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@RoggeOhta