Upgrade baseui to 9.116.3#5194
Conversation
sfc-gh-tszerszen
requested review from
AnOctopus,
jroes,
kmcgrady and
tconkling
as code owners
sfc-gh-tszerszen
force-pushed
the
update-baseweb-ui
branch
2 times, most recently
from
2d36524 to
a126169
Compare
sfc-gh-tszerszen
force-pushed
the
update-baseweb-ui
branch
6 times, most recently
from
510801f to
1b92229
Compare
sfc-gh-tszerszen
force-pushed
the
update-baseweb-ui
branch
3 times, most recently
from
d4166d4 to
da49f46
Compare
sfc-gh-tszerszen
force-pushed
the
update-baseweb-ui
branch
2 times, most recently
from
796f161 to
6a5e522
Compare
sfc-gh-tszerszen
force-pushed
the
update-baseweb-ui
branch
from
3f4eac0 to
87d8c5e
Compare
| () => { | ||
| this.pendingElementsBuffer = this.state.elements | ||
| this.widgetMgr.removeInactive(fromJS([])) | ||
| this.widgetMgr.removeInactive(new Set([])) |
There was a problem hiding this comment.
What is the reason why fromJS had to be changed here?
There was a problem hiding this comment.
In baseui@9.116.3 widgetMgr.removeInactive recieves Set instead of Immutable Collection, the tschecks and compilation failed with previous code
| Bar: { | ||
| style: ({ $theme }: { $theme: any }) => ({ | ||
| width, | ||
| width: width ? width.toString() : "100%", |
There was a problem hiding this comment.
Was the value from width changed to string instead of int in baseUI? What is the reason it needs the 100% now as fallback, would it also be an option to not set width at all when it is empty?
There was a problem hiding this comment.
Now baseui needs width as a string, but it can also accept undefined value, good call we should pass undefined instead of "100% 👍 I've changed that
|
I did had a quick look on the core-preview and there seems to be a minor style issue with expander: That's how it looks with the change (see the small shadow): That's how it should look like: |
Thanks for finding this out, I've commited the change in remove border bottom style from exapnder and we should be good to go 👍 |
* develop: Add type annotations to `map` (#5246) Up version to 1.12.2 (#5230) Add type annotations to `pydeck_chart` (#5242) Add type annotations to `graphviz_chart` (#5243) TYP: Complete type annotations for `_iframe` and `_html` (#5244) Revert padding updates to charts, dataframes and images (#5229) Improve compatibility with pydeck v0.8.1 (#5248) Remove unused dependency - pretty-quick (#5238) Upgrade baseui to 9.116.3 (#5194) Improve dataframe column and table sizing (#5221) Convert widget serde function closures to objects (#5226) Make sure st.json doesn't explode when passed a list (#5223)
4 participants
📚 Context
Please describe the project or issue background here
When typing XX:2X, XX:4X, XX:5X into timeInput with keyboard only and pressing enter time is not selected, see Issue-#4943. This happens because state is not updated when user types this kind of time.
@lukasmasuch found out that it's actually a bug within baseui and upgrading it to 9.114.0 fixes the issue. This PR upgrades baseui to desired version.
What kind of change does this PR introduce?
🧠 Description of Changes
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
Tests in expander needed to be updated, because of different rendering, but behaviour seems to be ok
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.