Skip to content

fix: resolve dunkscore parse issue #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
poteto0 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: resolve dunkscore parse issue #598

poteto0 wants to merge 3 commits into from

Conversation

@poteto0
Copy link

@poteto0 poteto0 commented Nov 17, 2025 •
edited
Loading

I'm not sure that best response structure, but this resolve issue.

resolve issue as below
@poteto0
Copy link
Author

poteto0 commented Nov 23, 2025

@rsforbes can you review this?
brandonhawi
brandonhawi reviewed Dec 7, 2025
View reviewed changes
Copy link

@brandonhawi brandonhawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but overall looks good 👍🏼
@poteto0
Copy link
Author

poteto0 commented Dec 8, 2025

@brandonhawi
Thanks. I'll check in a few days
@poteto0
Copy link
Author

poteto0 commented Dec 11, 2025

@brandonhawi I reflected the review
brandonhawi
brandonhawi reviewed Dec 11, 2025
View reviewed changes
Copy link

@brandonhawi brandonhawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contributions. Left one small documentation comment but otherwise awesome work!
@poteto0 @brandonhawi
Update src/nba_api/stats/endpoints/_parsers/dunkscoreleaders.py
be3c1e1 
Co-authored-by: Brandon Hawi <brandonhawi1@gmail.com>
@poteto0
Copy link
Author

poteto0 commented Dec 12, 2025 •
edited
Loading

@brandonhawi thank you. I commited your comment
@poteto0
Copy link
Author

poteto0 commented Dec 26, 2025

Any update here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@poteto0 @brandonhawi