fix: grid not rendering on scroll drag#4750
Open
lukecotter wants to merge 3 commits into
Open
Conversation
With dataTree:false and a fixed height grid, if I dragged the scroll halfway down all rows would vanish. This is because `rowsToRender` would end up being NaN after initial render due to `row.getHeight()` being undefined and the sum for `rowsHeight` resulting in NaN, which caused `avgRowHeight` to also be NaN. With `rowsToRender` and `avgRowHeight` nothing rendered. Sometimes heightInitialized would be true because setCellHeight had be called. The row outerHeight is 0 still, we now check offsetHeight and vDomRowHeight as fallback.
Collaborator
|
Hey @lukecotter ! Could you give us a little example of the code? This is my code but I can't replicate the issue you mentioned. |
Contributor
Author
…ing-on-scroll-drag # Conflicts: # src/js/core/rendering/renderers/VirtualDomVertical.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: ensure height is not undefined
With a
variableHeight: trueon a column and a fixed height grid, if I dragged the scroll halfway down all rows would vanish.Setting
dataTree: trueis a workaround for the issue.This is because
rowsToRenderwould end up being NaN after initial render dueto
row.getHeight()being undefined and the sum forrowsHeightresulting in NaN, which causedavgRowHeightto also be NaN.With
rowsToRenderandavgRowHeightnothing rendered.Sometimes heightInitialized would be true because setCellHeight had be called.
The row outerHeight was undefined still, we now check offsetHeight and vDomRowHeight as fallback.