test: skip real-transport tests on Windows (they require os.fork) - #332
Open
K4bain wants to merge 1 commit into
Open
test: skip real-transport tests on Windows (they require os.fork)#332K4bain wants to merge 1 commit into
K4bain wants to merge 1 commit into
Conversation
…the server subprocess)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
serverfixture in both real-transport test modules spawns the FastAPI app in a subprocess viamultiprocessing.get_context("fork"):os.fork()does not exist on Windows, so every test intest_sse_real_transport.pyandtest_http_real_transport.pyerrors withValueError: cannot find context for 'fork'when the suite is run on Windows (forkwas chosen overspawnto avoid pickling the FastAPI app, so there is no drop-in substitute).This PR adds a module-level
pytestmark = pytest.mark.skipif(os.name == "nt", ...)to both modules, with a comment explaining why. Behavior on POSIX (including CI) is unchanged — the tests still run there. Locally on Windows the suite now reports69 passed, 20 skippedinstead of 20 errors.