-
Notifications
You must be signed in to change notification settings - Fork 259
feat: add @file directive #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is ready now as well. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 88.45% 88.50% +0.04%
==========================================
Files 104 105 +1
Lines 11161 11226 +65
==========================================
+ Hits 9873 9936 +63
- Misses 1288 1290 +2 ☔ View full report in Codecov by Sentry. |
@meskill Do the codecov issues on this make sense? I think the testing is good enough. Not sure why the missed lines are missed. |
They do. You can check the report or annotations in the pr. It mostly about some invalid cases check and usage of file inside |
ohhhhh! thanks. i didn't even think about |
Alright, added tests for expr as well. |
1b9daa0
to
8445b88
Compare
Action required: PR inactive for 2 days. |
Closing this PR as reworking it to use |
Summary:
Adds the
@file
directive, like described in #932. Usescompile_const
under the hood for max code reuse and to make sure we only read a file once.Issue Reference(s):
Fixes #932
/claim #932
Also partly addresses #764
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>