feat: add port to global options for default node #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add global tailscale.port option - added proper handling for default node: If no name is specified it used hardcoded string "caddy" but the docs say that it is using the binary name Signed-off-by: khartahk <khartahk@users.noreply.github.com>
khartahk
force-pushed
the
globa-config-port-for-default-node
branch
from
edcffe0 to
968fa2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no name is specified it used hardcoded string "caddy" but the docs
say that it is using the binary name
When
bind tailscale/is used without a node name, Caddy's network address parser returns an empty string for host, and the code was passing that empty string togetNode("")which would create a node with no proper name, causing Tailscale to auto-generate a conflicting name likecaddy-1and use a random port instead of the configured global port.I've built it locally and tested that it works for my use case.
tailscale.portsets the port to the global nonamed nodetailscale.<SERVER>.portsets it like normaly for the<SERVER>