Migrate negative arbitrary values to negative bare values #18212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Jun 3, 2025
RobinMalfait
commented
Jun 3, 2025
| let rootPrefix = '' | ||
| if (spacingMultiplier !== null && spacingMultiplier < 0) { | ||
| rootPrefix = '-' | ||
| spacingMultiplier = Math.abs(spacingMultiplier) |
There was a problem hiding this comment.
This is also an option 🤔
Suggested change
| spacingMultiplier = Math.abs(spacingMultiplier) | |
| spacingMultiplier *= -1 |
1 task
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements to the upgrade tool where it can now also migrate negative arbitrary values to negative bare values.
We already had support for the positive version of this:
But now it can also handle negative values:
The only tricky part here is that we had to hoist the
-sign. Before this PR, we were actually generatingmb--128and that is invalid so it was thrown out.Test plan