Do not allow variants to start with - or _
#18867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
added a commit
that referenced
this pull request
Sep 3, 2025
#18869) This PR fixes a small parsing issue where variants such as `@-2xl:flex` would parse, but were handled as-if they were `@2xl:flex` instead. Noticed this while working on: #18867 This is because when we parse normal variants like `data-foo` then we want to have a `data` root and a `foo` value, not a `-foo` value. If you are now using `@-2xl:flex`, then no CSS will be generated for this anymore. If you were relying on this for some reason, you should use `@2xl:flex` instead. ## Test plan Before: <img width="862" height="586" alt="image" src="https://github.com/user-attachments/assets/b5993ca6-f907-49af-b5bd-b7206c8300e1" /> After: <img width="862" height="586" alt="image" src="https://github.com/user-attachments/assets/351f45e4-4cd3-451c-ae2a-c52c3e770629" /> --------- Co-authored-by: Jordan Pittman <thecrypticace@gmail.com>
RobinMalfait
force-pushed
the
fix/issue-18863
branch
from
fc1f0ea to
4313f9b
Compare
This will disallow variants starting with `-` (or existing on its own)
RobinMalfait
force-pushed
the
fix/issue-18863
branch
from
4313f9b to
c5c3ed7
Compare
Co-Authored-By: Jordan Pittman <thecrypticace@gmail.com>
thecrypticace
approved these changes
Sep 3, 2025
RobinMalfait
added a commit
that referenced
this pull request
Sep 3, 2025
This PR is a followup of #18867, but this time we won't allow `@custom-variant` to end with `-` or `_`. The same reasoning applies here where Oxide doesn't pick this up but Intellisense and Tailwind CSS' core does. --------- Co-authored-by: Jordan Pittman <thecrypticace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where custom variants with just
-in the name were allowed but weren't actually picked up by Oxide so you couldn't use them anyway.The reason we allow
-is forkebab-style-variants, which is very common, but you shouldn't use-,--or more in a variant name.It doesn't really solve the issue (#18863), but it fixes the inconsistencies in that exist today.
Inconsistencies:
-:flex--:flex--as a CSS variable instead of a utility. This means that the--:flexwas considered a CSS variable and skipped during compilation.--:flexbeing "correct".With this PR, the matrix looks like this now:
-:flex--:flexThis should not be considered a breaking change because Oxide didn't pick up candidates with variants that start with a
-. CSS for these candidates was never generated before.Closes: #18863