fix: preserve aspect data when applying merged config during snapFromScope #10056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Scope When merging lanes using bare-scope merge, aspect data fields (like packageName) were being lost. This occurred because: 1. Components are loaded from scope with correct data 2. Merged config is applied via addAspectsFromConfigObject 3. ExtensionDataList.fromConfigObject creates entries with only config, no data 4. When merging configs, the config-only entries overwrite existing entries with data The fix restores data fields from original extensions after merging configs. This ensures components that skip aspect loading (PR #9570 optimization) still have their data preserved. Also added detailed comments explaining the PR #9570 optimization and how components that skip aspect recalculation rely on data preservation and the addDeps() method for dependency updates.
GiladShoham
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where aspect data fields (like
packageName,componentRangePrefix) were being lost during bare-scope lane merges.Root Cause
When merging lanes using bare-scope merge:
addAspectsFromConfigObjectExtensionDataList.fromConfigObjectcreates entries with only config, no dataThe Fix
Added code in
addAspectsFromConfigObjectto restore data fields from original extensions after merging configs:This ensures components that skip aspect loading (PR #9570 optimization) still have their data preserved.