Skip to content

fix: resolve workspace.jsonc conflict around classnames package #10078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidfirst merged 5 commits into from
Nov 17, 2025
Merged

fix: resolve workspace.jsonc conflict around classnames package #10078

davidfirst merged 5 commits into from
Nov 17, 2025

Conversation

@davidfirst
Copy link
Member

@davidfirst davidfirst commented Nov 17, 2025 •
edited
Loading

Fixes

  • Resolved workspace.jsonc conflict around classnames package version
  • Fixed MCP SDK breaking changes from v1.12.0 to v1.22.0:
    • Fixed content type validation to check type before accessing text property (handles new multi-type content system: text, image, audio, etc)
    • Updated test expectations: SDK now returns error results with isError flag instead of throwing exceptions
@davidfirst davidfirst enabled auto-merge (squash) November 17, 2025 18:27
@davidfirst
update @modelcontextprotocol/sdk to have the version consistent betwe…
22caa3d 
…en the workspace and the capsules
@davidfirst
fix: handle MCP SDK breaking change for content type validation
c4c7e2b 
The @modelcontextprotocol/sdk package introduced multiple content types (text, image, audio, etc). Updated code to validate content type is text before accessing text property, throwing descriptive error for unexpected types.
@davidfirst
fix: adapt to MCP SDK breaking changes from v1.12 to v1.22
a0d1a71 
- Changed schema definition from Record<string, any> to z.object() which is required by new SDK
- SDK now handles zod validation automatically and returns errors with isError flag instead of throwing
- Removed manual validation code since SDK validates automatically
- Updated test to check for error result with isError flag instead of expecting thrown exception
- Fixed content type validation to throw descriptive error for non-text content
@davidfirst
fix: use ZodRawShape instead of ZodObject for MCP SDK compatibility
f0f3eef 
The server.tool() method expects ZodRawShape (Record<string, any> with zod schemas) not a compiled ZodObject from z.object(). This fixes the TypeScript compilation error while maintaining automatic validation.
@davidfirst davidfirst merged commit cd1f0f3 into master Nov 17, 2025
11 checks passed
@davidfirst davidfirst deleted the fix-workspace-jsonc-conflict-classnames branch November 17, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@davidfirst @GiladShoham