Skip to content

Conversation

@davidfirst
Copy link
Member

Summary

Fixes an issue where bit ci merge continued executing despite encountering workspace.jsonc conflicts during the checkout step, potentially leading to build failures and inconsistent dependency states.

Changes

  • Added conflict detection after bit checkout head in bit ci merge
  • Stops execution immediately when workspace.jsonc conflicts are detected
  • Provides clear error message instructing users to run bit checkout head manually
  • Added e2e test to verify the fix

Behavior

Before:

  • bit ci merge would print workspace.jsonc conflict warnings but continue
  • Would proceed with tagging, exporting, and git operations
  • Could result in builds with unresolved dependency conflicts

After:

  • bit ci merge detects workspace.jsonc conflicts after checkout
  • Stops immediately with clear error message
  • Instructs users to manually resolve conflicts via bit checkout head

Related

Example from CircleCI where this issue occurred:
https://app.circleci.com/pipelines/github/teambit/bit/44621/workflows/9461c6c8-ac58-4c34-8abe-9fe0d99fd0ba/jobs/392816

Test Plan

  • E2e test added in e2e/harmony/ci-commands.e2e.ts
  • Verifies that workspace.jsonc conflicts halt the CI merge process
  • Confirms appropriate error message is shown
…ing merge

During 'bit ci merge', if the checkout step encounters workspace.jsonc conflicts
due to conflicting dependency versions, the process now stops immediately with
a clear error message instead of continuing with tagging and export operations.

This prevents the CI from proceeding with invalid dependency state and instructs
users to manually run 'bit checkout head' to resolve the conflicts.

Fixes the issue where CI would continue after printing workspace.jsonc conflict
warnings, leading to potential build failures or inconsistent dependency states.
@davidfirst davidfirst enabled auto-merge (squash) November 19, 2025 15:19
@davidfirst davidfirst merged commit 211b834 into master Nov 19, 2025
11 checks passed
@davidfirst davidfirst deleted the fix/ci-merge-stop-on-workspace-jsonc-conflicts branch November 19, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants