Skip to content

perf: use Set for faster snap filtering in getDivergeDataBetweenTwoSnaps #10085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidfirst merged 1 commit into from
Nov 21, 2025
Merged

perf: use Set for faster snap filtering in getDivergeDataBetweenTwoSnaps #10085

davidfirst merged 1 commit into from
Nov 21, 2025

Conversation

@davidfirst
Copy link
Member

@davidfirst davidfirst commented Nov 21, 2025 •
edited
Loading

Replace array .includes() with Set.has() for O(1) lookup when filtering common snaps between source and target subgraphs. This improves performance from O(n*m) to O(n+m) when computing diverge data.

The fix has been created by @guysaar223
@davidfirst davidfirst enabled auto-merge (squash) November 21, 2025 20:49
@davidfirst davidfirst merged commit e60bfae into master Nov 21, 2025
12 checks passed
@davidfirst davidfirst deleted the perf/optimize-diverge-data-snap-filtering branch November 21, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@davidfirst @luvkapur