fix(webpack): disable static directory watcher to prevent watching entire workspace #10116
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tire workspace When Chokidar watches a non-existent path, it recursively walks up the directory tree to find an existing parent directory to watch. Since the static public directories typically don't exist, this causes Chokidar to watch the entire workspace root, triggering unnecessary file system events on every file change.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a performance issue where webpack-dev-server's static directory watcher would inadvertently watch the entire workspace root when the configured static directory doesn't exist, causing unnecessary file system events and resource waste.
- Disables static directory watching in webpack dev server configurations
- Adds clear documentation explaining the rationale for the change
- Prevents Chokidar from recursively watching parent directories when target paths don't exist
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scopes/webpack/webpack/config/webpack.dev.config.ts | Disabled static directory watching and added explanatory comment about the Chokidar behavior |
| scopes/ui-foundation/ui/webpack/webpack.dev.config.ts | Disabled static directory watching and added explanatory comment about the Chokidar behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GiladShoham
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When webpack-dev-server's static directory watcher is enabled but the directory doesn't exist (which is typically the case), Chokidar recursively walks up the directory tree to find an existing parent to watch. This causes it to watch the entire workspace root directory, triggering unnecessary file system events on every file change.
Investigation findings:
preview/teambit.harmony/node/publicdon't exist/tmp/workspace)Changes:
watch: truein both webpack dev configs (webpack/config/webpack.dev.config.tsandui-foundation/ui/webpack/webpack.dev.config.ts)Static files rarely change during development, and if they do, a server restart is acceptable.