-
Notifications
You must be signed in to change notification settings - Fork 946
update core-envs to latest typescript-compiler with cross-env tsconfig fix #10135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Bit workspace configuration to explicitly associate all components with their respective environments by adding "config" sections to the .bitmap file. This change supports the latest typescript-compiler's cross-environment tsconfig handling, ensuring that each component is compiled with its own environment's tsconfig rather than inheriting from the importer's configuration.
Key changes:
- Adds explicit environment configuration to all component entries in
.bitmap - Ensures proper isolation of TypeScript compiler settings across different environments
- Prevents strict mode compilation errors when components with different env settings depend on each other
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.circleci/config.yml
Outdated
| key: bitsrc-registry10 | ||
| - restore_cache: | ||
| key: core-aspect-env-v0.1.0-v1 | ||
| key: core-aspect-env-v0.1.2-v1 |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CircleCI cache key references core-aspect-env-v0.1.2-v1, but all component configurations in .bitmap reference teambit.harmony/envs/core-aspect-env@0.1.3. This version mismatch could lead to cache invalidation issues or components using a different environment version than expected. The cache key version should match the actual environment version being used by components.
| key: core-aspect-env-v0.1.2-v1 | |
| key: core-aspect-env-v0.1.3-v1 |
.circleci/config.yml
Outdated
| key: bitsrc-registry10 | ||
| - restore_cache: | ||
| key: core-aspect-env-v0.1.0-v1 | ||
| key: core-aspect-env-v0.1.2-v1 |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CircleCI cache key references core-aspect-env-v0.1.2-v1, but all component configurations in .bitmap reference teambit.harmony/envs/core-aspect-env@0.1.3. This version mismatch could lead to cache invalidation issues or components using a different environment version than expected. The cache key version should match the actual environment version being used by components.
| key: core-aspect-env-v0.1.2-v1 | |
| key: core-aspect-env-v0.1.3-v1 |
.circleci/config.yml
Outdated
| command: cd bit && bbit install | ||
| - save_cache: | ||
| key: core-aspect-env-v0.1.0-v1 | ||
| key: core-aspect-env-v0.1.2-v1 |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CircleCI cache key references core-aspect-env-v0.1.2-v1, but all component configurations in .bitmap reference teambit.harmony/envs/core-aspect-env@0.1.3. This version mismatch could lead to cache invalidation issues or components using a different environment version than expected. The cache key version should match the actual environment version being used by components.
| key: core-aspect-env-v0.1.2-v1 | |
| key: core-aspect-env-v0.1.3-v1 |
.circleci/config.yml
Outdated
| key: bitsrc-registry10 | ||
| - restore_cache: | ||
| key: core-aspect-env-v0.1.0-v1 | ||
| key: core-aspect-env-v0.1.2-v1 |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CircleCI cache key references core-aspect-env-v0.1.2-v1, but all component configurations in .bitmap reference teambit.harmony/envs/core-aspect-env@0.1.3. This version mismatch could lead to cache invalidation issues or components using a different environment version than expected. The cache key version should match the actual environment version being used by components.
| key: core-aspect-env-v0.1.2-v1 | |
| key: core-aspect-env-v0.1.3-v1 |
Updates core-envs to use the latest typescript-compiler that includes the fix for cross-env tsconfig project references.
This ensures that when a component imports a dependency using a different environment with different tsconfig settings, each component is compiled with its own env's tsconfig rather than the importer's.
Fixes the issue where
bit buildwould fail with strict mode errors when a strict-env component imports a permissive-env component.