Skip to content

Conversation

@davidfirst
Copy link
Member

Compilers using transpileComponent write directly to the filesystem with a single outputDir. After PR #10125 fixed the outputDir to use bit_roots for correct peer resolution, the compiled files were no longer available in node_modules/<pkg>.

This fix copies all compiled files from the outputDir to all other dist directories (injected dirs) after transpileComponent completes, ensuring bundlers like esbuild have their output available in all required locations.

Compilers using transpileComponent write directly to the filesystem with a single
outputDir. After PR #10125 fixed the outputDir to use bit_roots for correct peer
resolution, the compiled files were no longer available in node_modules/<pkg>.

This fix copies all compiled files from the outputDir to all other dist directories
(injected dirs) after transpileComponent completes, ensuring bundlers like esbuild
have their output available in all required locations.
Copilot AI review requested due to automatic review settings December 23, 2025 22:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where compiled files from compilers using transpileComponent were not available in all required dist directories. After PR #10125 changed the outputDir to use bit_roots for proper peer resolution, compiled files were only written to one location but needed to be available in multiple locations including node_modules/<pkg>.

Key Changes

  • Added new method copyCompiledFilesToOtherDists() to copy compiled files from the compiler's output directory to all other required dist directories
  • Integrated the copy operation into the compilation workflow by calling it after transpileComponent completes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@davidfirst davidfirst merged commit a6e658a into master Dec 24, 2025
12 checks passed
@davidfirst davidfirst deleted the fix/copy-compiled-files-to-all-dist-dirs branch December 24, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants