refactor(e2e): split large lanes.e2e.ts into focused test files for better parallel execution #9823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter parallel execution
GiladShoham
approved these changes
Jul 14, 2025
…s-e2e-for-parallel-testing
- Create jest-fixtures.ts with shared test fixture functions - Remove fixture functions from jest.e2e.ts to prevent unintended test execution - Update imports in build-cmd.e2e.ts and merge-lanes-edge-cases.e2e.ts - Fix issue where importing specFileFailingFixture caused entire jest.e2e.ts test suite to run
CircleCI timing data stores absolute paths but glob was returning relative paths, causing autodetection to fail and fall back to name-based weighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the massive 1603-line lanes.e2e.ts file into 9 smaller, focused test files organized by functionality. This enables better load balancing when running e2e tests in parallel across 25 machines. Each new file focuses on a specific aspect of lane operations (basic operations, snapping, export, import, merging, diffing, multiple scopes, forking, and management) and ranges from 150-400 lines.
Also, change Circle to split the test by timing and fix the glob pattern to make this works.