Only install enum34 for Python <= 3.4 - #171
Merged
Merged
Conversation
|
Thanks @lgeiger for the PR. Please take a look at at https://github.com/tensorflow/model-optimization/blob/master/CONTRIBUTING.md and follow #131 as we make this project ready for contributors to contribute. We actually still need some infrastructure to accept PRs and will accept this once that happens. Did this cause a breakage on Python > 3.4? |
alanchiao
self-requested a review
December 5, 2019 22:28
Contributor
Author
It only installs an unnecessary package. At least for me it didn't cause any obvious breakage. |
alanchiao
approved these changes
Dec 30, 2019
|
Looks good to me. @lgeiger : could you resolve the merge conflicts? We can merge it after. |
alanchiao
added
the
ready to pull
tf-mot-copybara
pushed a commit
that referenced
this pull request
Jan 2, 2020
PiperOrigin-RevId: 287842873
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also how TensorFlow handles it: https://github.com/tensorflow/tensorflow/blob/6c8cbdceccce20f886a08b0cf00ac2e783ac524c/tensorflow/tools/pip_package/setup.py#L56