Skip to content

Move clustering end-to-end test into separate file - #280

Merged
tf-mot-copybara merged 1 commit into
tensorflow:masterfrom
arovir01:toupstream/cluster_end_to_end_test
Mar 3, 2020
Merged

Move clustering end-to-end test into separate file#280
tf-mot-copybara merged 1 commit into
tensorflow:masterfrom
arovir01:toupstream/cluster_end_to_end_test

Conversation

@arovir01

@arovir01 arovir01 commented Mar 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR addresses the proposal raised in this comment and moves testValuesRemainClusteredAfterTraining() from cluster_wrapper_test.py into a separate file named cluster_integration_test.py.
@googlebot googlebot added the cla: yes PR contributor has signed CLA label Mar 2, 2020
@arovir01

arovir01 commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

@akarmi Please review.
@alanchiao

alanchiao commented Mar 2, 2020 •
edited
Loading

Copy link
Copy Markdown

@arovir01 : FYI that we've been placing such scoped end-to-end tests under quantize_integration_test.py and prune_integration_test.py. We also have quantize_functional_test.py for the larger ones (we have it just for MNIST and testing conversion to TFLite also).
@arovir01

arovir01 commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the observation, Alan. I will rename the file and the class for consistency with Pruning and Quantization.
@arovir01
arovir01 force-pushed the toupstream/cluster_end_to_end_test branch from 48bbb19 to 247d534 Compare March 3, 2020 10:08
@arovir01
Move clustering end-to-end test into separate file
de3555f 
* Moved testValuesRemainClusteredAfterTraining() from cluster_wrapper_test.py
  to cluster_integration_test.py
* Updated BUILD with new cluster_integration_test py_test target
@arovir01
arovir01 force-pushed the toupstream/cluster_end_to_end_test branch from 247d534 to de3555f Compare March 3, 2020 10:09
@akarmi

akarmi commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Thanks, looks good to me. @alanchiao, please merge this.

We also have quantize_functional_test.py for the larger ones (we have it just for MNIST and testing conversion to TFLite also).

@alanchiao, I checked quantize_functional_test.py and it looks to me as it could be a good idea to add such a test for clustering as well. We already have an MNIST example so that it should be fairly straightforward to convert it to a test. We would still keep a standalone example as well.
@alanchiao alanchiao added the ready to pull Working to get PR submitted to internal repository, after which merging to Github happens. label Mar 3, 2020
@alanchiao alanchiao self-assigned this Mar 3, 2020
@tf-mot-copybara
tf-mot-copybara merged commit 7c8ac19 into tensorflow:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes PR contributor has signed CLA ready to pull Working to get PR submitted to internal repository, after which merging to Github happens.

5 participants

@arovir01 @alanchiao @akarmi @googlebot @tf-mot-copybara