[WIP] Add pre-commit and lint workflow#2251
Draft
peytondmurray wants to merge 3 commits intotensorflow:masterfrom
Draft
[WIP] Add pre-commit and lint workflow#2251peytondmurray wants to merge 3 commits intotensorflow:masterfrom
peytondmurray wants to merge 3 commits intotensorflow:masterfrom
Conversation
smokestacklightnin
previously approved these changes
Sep 18, 2024
Member
smokestacklightnin
left a comment
smokestacklightnin
left a comment
There was a problem hiding this comment.
@peytondmurray I made two changes, fyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow to run pre-commit on every PR; a sensible initial set of pre-commit hooks is also included, and a new optional dependency has been added for
pre-commit.Currently blocked until
#2252#4119 is merged, at which point the this will be marked as ready for review, and the lint workflow should run successfully.Later on, we'll want to start re-enabling various rules and cleaning up rule violations.