Exclude stubdata and i18n BUILD.bazel from ICU 77 repository archive - #1543
Merged
Merged
Conversation
In ICU 77, BUILD.bazel files were added upstream under icu4c/source/stubdata/ and icu4c/source/i18n/. Because custom_http_archive only excluded icu4c/source/common/BUILD.bazel, Bazel treated icu4c/source/stubdata/ as a separate package, preventing glob(["icu4c/source/stubdata/*.cpp"]) in //third_party/icu:BUILD.bzl from matching stubdata.cpp. Consequently, U_ICUDATA_ENTRY_POINT (icudt77_dat) was omitted from the build, resulting in undefined symbol errors upon importing tensorflow_text. Excluding stubdata/BUILD.bazel and i18n/BUILD.bazel and including stubdata/*.h in hdrs allows stubdata to be cleanly compiled into icuuc, resolving icudt77_dat. Fixes tensorflow#1541
Steboss
added a commit
to NVIDIA/JAX-Toolbox
that referenced
this pull request
Aug 25, 2026
Next `tensorflow-text` version introduces [this bug](tensorflow/text#1541). The issue was fixed in [1543](tensorflow/text#1543), but it's not been released yet as a new version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ICU 77, BUILD.bazel files were added upstream under
icu4c/source/stubdata/andicu4c/source/i18n/. Becausecustom_http_archiveonly excludedicu4c/source/common/BUILD.bazel, Bazel treatedicu4c/source/stubdata/as a separate package, preventingglob(["icu4c/source/stubdata/*.cpp"])in//third_party/icu:BUILD.bzlfrom matchingstubdata.cpp. Consequently,U_ICUDATA_ENTRY_POINT(icudt77_dat) was omitted from the build, resulting in undefined symbol errors upon importingtensorflow_texton systems without ICU 77.Excluding
stubdata/BUILD.bazelandi18n/BUILD.bazeland includingstubdata/*.hinhdrsallowsstubdata.cppto be cleanly compiled intoicuuc, resolvingicudt77_dat.Fixes #1541