Fix custom Video/Audio switcher in Plugins menu #3174
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to th-ch#3167 Update `setVideoState` function and `switchButtonDiv` event listener to handle transition back to audio mode. * **Update `setVideoState` function** - Correctly handle the transition back to audio mode. - Update the `hideVideo` property in the plugin configuration. - Use `this.config` instead of `config` to set options and update checkbox state. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/th-ch/youtube-music/issues/3167?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the custom Video/Audio switcher behavior by ensuring the plugin configuration is updated using the correct reference.
- Update setVideoState to toggle the hideVideo property using this.config.
- Update plugin options and checkbox state to refer to this.config instead of a local config variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3167
Update
setVideoStatefunction andswitchButtonDivevent listener to handle transition back to audio mode.setVideoStatefunctionhideVideoproperty in the plugin configuration.this.configinstead ofconfigto set options and update checkbox state.For more details, open the Copilot Workspace session.