feat(plugin): support authenticated proxy #3175
Open
+435
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images and logs:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the auth-proxy-adapter plugin to support authenticated proxies by starting a local unauthenticated proxy server that forwards requests to a configured authenticated proxy.
- New menu items allow configuration of hostname and port for the proxy adapter.
- The backend is extended to intercept and forward SOCKS proxy connections via an upstream proxy.
- The application startup is updated to conditionally use the auth-proxy-adapter proxy settings.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/auth-proxy-adapter/menu.ts | Adds menu items for configuring hostname and port with a minor validation discrepancy. |
| src/plugins/auth-proxy-adapter/index.ts | Initializes the plugin with its configuration and backend integration. |
| src/plugins/auth-proxy-adapter/config.ts | Defines the interface and default configuration for the auth-proxy-adapter plugin. |
| src/plugins/auth-proxy-adapter/backend/types.ts | Provides type definitions for backend handling related to SOCKS connections. |
| src/plugins/auth-proxy-adapter/backend/main.ts | Implements the core backend logic for handling SOCKS4/5 requests through the upstream proxy. |
| src/plugins/auth-proxy-adapter/backend/index.ts | Re-exports backend definitions. |
| src/index.ts | Updates application startup logic to use the local proxy if the auth-proxy-adapter is enabled. |
Files not reviewed (2)
- src/i18n/resources/en.json: Language not supported
- src/i18n/resources/zh-CN.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Maybe handleSocks4 can be removed because the SOCKS4 protocol does not have proxy authentication. |
I removed handleSocks4 and the application imported the ‘socks’ package because it needed to turn on the socket local server to forward requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new plugin to support authenticated proxy.
The auth-proxy-adapter plugin will start a local unauthenticated proxy server (default
socks5://127.0.0.1:4545) that forwards requests to an authenticated proxy server configured in the application settings, supporting proxy in the formatsocks5://username:password@your_server_ip:port.When enabled, the plugin intercepts
app.commandLine.appendSwitch('proxy-server', proxyToUse)and changes the application's proxy to use the local proxy server.Fixes #743