feat: add MaxRetires config to cos, gcs and obs #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
ashwanthgoli
force-pushed
the
gcs-disable-retires
branch
from
61bb8b2 to
220d250
Compare
8 tasks
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
ashwanthgoli
force-pushed
the
gcs-disable-retires
branch
from
b07fd8d to
165faea
Compare
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
|
would really appreciate a review on this one, thank you! |
|
minio-go v7.0.80 adds support to configure retries, but it requires go@1.22 |
Signed-off-by: Ashwanth Goli <iamashwanth@gmail.com>
ashwanthgoli
force-pushed
the
gcs-disable-retires
branch
from
9aefacd to
ac8c1e1
Compare
fpetkovski
approved these changes
Nov 11, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a configuration option for GCS to disable retries. GCS client retries idempotent operations by default.This allows disabling retries incase someone wants to handle them at a higher level
Introduces
MaxRetriesconfiguration for gcs, cos and obs providers.Already supported by a few providers but the naming isn't consistent
Not supported yet by the following:
bce.NewNoRetryPolicy()but there is no public api to update max retries.Verification