feat(compact): Add Pushgateway metrics support for one-shot runs #8488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces the ability for the `thanos compact` command to push its metrics to a Prometheus Pushgateway when running in one-shot mode (without the `--wait` flag). This is particularly useful for monitoring the compactor when it is run as a periodic batch job, such as a cron job. The following changes have been made: - Refactored progress metric calculation to run in one-shot mode. - Added `--push-gateway.url` and `--push-gateway.job` flags to configure the Pushgateway endpoint and job name. - Implemented the logic to push all registered metrics upon successful completion of a one-shot compaction run. Signed-off-by: Enno Richter <enno@nerdworks.de>
elohmeier
force-pushed
the
compact-pushgateway
branch
from
0b4bf14 to
1e500c4
Compare
|
Added CHANGELOG entry. |
|
Docs CI failure is unrelated, I've pushed a fix here: #8494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change introduces the ability for the
thanos compactcommand topush its metrics to a Prometheus Pushgateway when running in one-shot
mode (without the
--waitflag).This is particularly useful for monitoring the compactor when it is run
as a periodic batch job, such as a cron job.
The following changes have been made:
--push-gateway.urland--push-gateway.jobflags to configurethe Pushgateway endpoint and job name.
completion of a one-shot compaction run.
Verification
I've tested the metrics availability in the --wait mode and with a Pushgateway.