fix(animation): Synchronize player and navbar animations#132
Merged
theovilardo merged 1 commit intomasterfrom Sep 9, 2025
Merged
fix(animation): Synchronize player and navbar animations#132theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
The animation for the navigation bar sliding out of view was not synchronized with the mini-player's expansion animation. This was because the navbar's translation was calculated using the square of the expansion fraction (`.pow(2)`), creating a non-linear animation curve that caused it to overlap with the player during the transition. This change removes the `.pow(2)` from the calculation, making the navbar's animation linear and directly proportional to the player's expansion. This ensures both elements move in tandem, maintaining a consistent separation and providing a smoother visual experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animation for the navigation bar sliding out of view was not synchronized with the mini-player's expansion animation. This was because the navbar's translation was calculated using the square of the expansion fraction (
.pow(2)), creating a non-linear animation curve that caused it to overlap with the player during the transition.This change removes the
.pow(2)from the calculation, making the navbar's animation linear and directly proportional to the player's expansion. This ensures both elements move in tandem, maintaining a consistent separation and providing a smoother visual experience.