Merged
Conversation
When using the 3-button system navigation, the `systemNavBarInset` needs to be added to the total height of the `FULL_WIDTH` navigation bar to prevent its content from being squashed. This change modifies the height calculation for the navigation bar's container in `MainActivity.kt` to account for the system navigation inset, ensuring the layout adapts correctly.
…tion When using the 3-button system navigation, the `systemNavBarInset` needs to be added to the total height of the navigation bar to prevent its content from being squashed. This change modifies the height calculation for the navigation bar's container in `MainActivity.kt` to account for the system navigation inset. The fix is now applied universally to both `DEFAULT` and `FULL_WIDTH` styles, ensuring the layout adapts correctly in all cases.
This commit fixes a layout issue where the navigation bar would get squashed when using the 3-button system navigation. The fix is implemented conditionally to support the distinct visual styles of the `DEFAULT` and `FULL_WIDTH` navigation bars. For the `FULL_WIDTH` style, the system navigation inset is added directly to the component's height to prevent content from being compressed. For the `DEFAULT` style, the system navigation inset is applied as external bottom padding. This preserves the intended "floating" appearance while ensuring the component has enough space and is not overlapped by the system navigation bar.
This commit refactors the padding calculation for the navigation bar in `MainActivity.kt`. The `systemNavBarInset` and `horizontalPadding` variables are now defined earlier in the composable function, outside the `Scaffold`'s `bottomBar` lambda. This improves readability and potentially avoids redundant calculations if these values were needed elsewhere within the `Scaffold`'s scope.
This commit reduces the height of the `PlayerInternalNavigationBar` when in full-width mode. The `NavBarContentHeightFullWidth` constant in `PlayerInternalNavigationBar.kt` has been changed from `94.dp` to `84.dp`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.