Feat: Improve player UI transition animation#177
Merged
theovilardo merged 1 commit intomasterfrom Oct 1, 2025
Merged
Conversation
The previous implementation of the player expansion animation waited for the background to fully expand before showing the full player UI. This resulted in a disjointed user experience. This change refactors the animation logic in `UnifiedPlayerSheet.kt` to make the full player UI appear and disappear gradually, in sync with the expansion and contraction of the player sheet. - Replaced `Animatable` states for alpha and translation with `derivedStateOf`. - The full player's UI alpha and translation are now calculated directly from the `playerContentExpansionFraction`. - This ensures a smooth and continuous transition, improving the overall user experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation of the player expansion animation waited for the background to fully expand before showing the full player UI. This resulted in a disjointed user experience.
This change refactors the animation logic in
UnifiedPlayerSheet.ktto make the full player UI appear and disappear gradually, in sync with the expansion and contraction of the player sheet.Animatablestates for alpha and translation withderivedStateOf.playerContentExpansionFraction.