Fix: Liked songs not playing as a playlist#181
Merged
theovilardo merged 1 commit intomasterfrom Oct 1, 2025
Merged
Conversation
This commit resolves an issue where the 'Liked Songs' list in the library did not function as a self-contained playlist. Previously, playing a song from the 'Liked' tab or using the shuffle button would incorrectly include all songs from the library in the playback queue. This has been fixed by: - Adding a `shuffleFavoriteSongs()` function to `PlayerViewModel` to specifically handle shuffling of the liked songs list. - Updating `LibraryScreen.kt` to call the new shuffle function when the shuffle button is pressed on the 'Liked' tab. - Modifying the song item's click handler in the 'Liked' tab to call `showAndPlaySong` with the `favoriteSongs` list, ensuring the playback queue is correctly limited to only liked songs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue where the 'Liked Songs' list in the library did not function as a self-contained playlist.
Previously, playing a song from the 'Liked' tab or using the shuffle button would incorrectly include all songs from the library in the playback queue.
This has been fixed by:
shuffleFavoriteSongs()function toPlayerViewModelto specifically handle shuffling of the liked songs list.LibraryScreen.ktto call the new shuffle function when the shuffle button is pressed on the 'Liked' tab.showAndPlaySongwith thefavoriteSongslist, ensuring the playback queue is correctly limited to only liked songs.