Cache lyrics fetched from internet#184
Merged
theovilardo merged 2 commits intotheovilardo:masterfrom Oct 4, 2025
Merged
Conversation
Owner
|
Hi! Thanks for your contribution! This was a big issue I've been meaning to fix for a while, so it's really much appreciated 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lyrics Cache Issue & Fix
Problem:
When you sync lyrics from the internet and then switch songs, the lyrics changes get lost. The app wasn't saving the fetched lyrics in memory, so every time you switched back to a song, it had to reload lyrics from scratch.
Fix:
Created a lyrics cache that stores lyrics in memory using Android's LruCache. Now when you fetch lyrics from the internet, they get cached immediately. When you switch songs and come back, the lyrics are still there in the cache - no more lost changes.
How it works:
The cache fixes the song-switching problem and makes lyrics load much faster.
Note: I'm not well proficient in Android Development and this code is assisted by AI. This is Tested and worked fine.