Added improved lyrics search#213
Conversation
|
As an aside, it might be a good idea to add some basic CI/CD using Github's Actions. A check to see if the project even compiles would be good to have. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
app/src/main/java/com/theveloper/pixelplay/data/repository/LyricsRepositoryImpl.kt
Show resolved
Hide resolved
|
@theovilardo I forgot, but this feature probably should be added to the in-app changelog too. |
|
Hi! Thanks for the contribution again, I'll make sure it's stated in the changelog
|
This PR adds:
/api/getmethod fails/api/searchwith the track name as query@theovilardo please check the styling of new UI elements as well as that the added code fits with the architecture. I tried to follow the example set by the rest of the codebase but I might've misinterpreted.
I'm curious to hear what you think! Let me know if the UI/flow is what you wanted.