Skip to content

Added improved lyrics search#213

Merged
theovilardo merged 5 commits intotheovilardo:masterfrom
SjVer:feature/improved-lyrics-search
Oct 9, 2025
Merged

Added improved lyrics search#213
theovilardo merged 5 commits intotheovilardo:masterfrom
SjVer:feature/improved-lyrics-search

Conversation

@SjVer
Copy link
Contributor

@SjVer SjVer commented Oct 9, 2025

This PR adds:

  • A secondary more generic lyrics search if lrclib's /api/get method fails
    • Uses /api/search with the track name as query
    • Presents the user with a list of results to pick from
  • Improved lyrics error messages when lyrics cannot be found
  • A reset lyrics option in the lyrics sheet
  • A reset all lyrics option in the settings menu

@theovilardo please check the styling of new UI elements as well as that the added code fits with the architecture. I tried to follow the example set by the rest of the codebase but I might've misinterpreted.

I'm curious to hear what you think! Let me know if the UI/flow is what you wanted.

@SjVer
Copy link
Contributor Author

SjVer commented Oct 9, 2025

As an aside, it might be a good idea to add some basic CI/CD using Github's Actions. A check to see if the project even compiles would be good to have.

@theovilardo theovilardo marked this pull request as ready for review October 9, 2025 11:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@theovilardo theovilardo merged commit 22a32d7 into theovilardo:master Oct 9, 2025
@SjVer
Copy link
Contributor Author

SjVer commented Oct 9, 2025

@theovilardo I forgot, but this feature probably should be added to the in-app changelog too.

@theovilardo
Copy link
Owner

Hi! Thanks for the contribution again, I'll make sure it's stated in the changelog

@theovilardo I forgot, but this feature probably should be added to the in-app changelog too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants