fix(player): Show lyrics dialog when song without lyrics starts#220
Merged
theovilardo merged 1 commit intomasterfrom Oct 10, 2025
Merged
fix(player): Show lyrics dialog when song without lyrics starts#220theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
When the LyricsSheet is open and the song changes to one that does not have lyrics, the sheet would previously just go blank. This change modifies the `LyricsSheet` to observe the current song. If the new song has no lyrics and lyrics are not currently being fetched, it now displays the `FetchLyricsDialog`. This allows the user to immediately search for or import lyrics for the new song, improving the user experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the LyricsSheet is open and the song changes to one that does not have lyrics, the sheet would previously just go blank.
This change modifies the
LyricsSheetto observe the current song. If the new song has no lyrics and lyrics are not currently being fetched, it now displays theFetchLyricsDialog. This allows the user to immediately search for or import lyrics for the new song, improving the user experience.