Fix: Update LibraryActionRow based on tab identity, not index#240
Merged
theovilardo merged 1 commit intomasterfrom Oct 12, 2025
Merged
Fix: Update LibraryActionRow based on tab identity, not index#240theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
The action buttons in the Library screen were not updating correctly when the tabs were reordered. This was because the logic in `LibraryActionRow` used a hardcoded page index (`currentPage == 3`) to determine which button to show. This change corrects the logic to use the `isPlaylistTab` boolean, which is derived from the tab's title. This makes the component robust and ensures the correct actions are displayed for the selected tab, regardless of its position in the tab row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action buttons in the Library screen were not updating correctly when the tabs were reordered. This was because the logic in
LibraryActionRowused a hardcoded page index (currentPage == 3) to determine which button to show.This change corrects the logic to use the
isPlaylistTabboolean, which is derived from the tab's title. This makes the component robust and ensures the correct actions are displayed for the selected tab, regardless of its position in the tab row.