Add experimental player UI loading tweaks#555
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ExperimentalSettingsScreen( | ||
| navController = navController, | ||
| playerViewModel = playerViewModel, | ||
| onNavigationIconClick = { navController.popBackStack() } |
There was a problem hiding this comment.
ExperimentalSettingsScreen declares its first parameter as _navController, but the navigation graph calls it with the named argument navController. Because Kotlin named arguments must match the parameter name, this composable will not compile (no parameter named navController / no value passed for parameter _navController) and the experimental settings route cannot build until the names are aligned.
Useful? React with 👍 / 👎.
Adds a new "Experimental" settings screen, accessible from the main settings page. This screen is now hidden from the bottom navigation bar. Refines the full player's loading placeholder UI: - Replaces the generic music note icon with the app's monochrome logo. - Updates placeholder shapes from sharp corners to rounded ones for a softer look. - Adjusts spacing, padding, and dimensions of placeholder elements for better visual balance and alignment with the final UI. - Changes the placeholder color derivation for improved theme consistency. Updates icons in the "Experimental" settings screen for better clarity: - `Delay album carousel`: `MusicNote` -> `ViewCarousel` - `Delay song title`: `Visibility` -> `LinearScale` - `Delay progress bar`: `PlayCircle` -> `Outlined.LinearScale` - `Show full player placeholders`: `Visibility` -> `Rectangle`
1 participant
Summary
Testing
./gradlew :app:compileDebugKotlin(fails: Android SDK is not available in this environment)Codex Task