Remove the use of sh in tests#612
Merged
theskumar merged 1 commit intotheskumar:mainfrom Feb 28, 2026
Merged
Conversation
This commit has the following benefits:
- Remove `sh` as a development dependency.
- Increase test coverage on Windows.
- Improve the robustness of some tests against leftover `.env` files in
the repository.
- This is not perfect yet: If you have a `.env` file in your
repository, it still disrupts some tests (for `find_dotenv`).
- Improve the readability of error messages for some tests.
theskumar
approved these changes
Feb 28, 2026
theskumar
added a commit
to bbc2/python-dotenv
that referenced
this pull request
Feb 28, 2026
* main: Remove the use of `sh` in tests (theskumar#612) # Conflicts: # tests/test_cli.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has the following benefits:
shas a development dependency..envfiles in the repository..envfile in your repository, it still disrupts some tests (forfind_dotenv).