[SvelteKit-pod]: fix: storybook#650
Open
iansamz wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for starter-dev canceled.
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
BigAB
reviewed
Dec 14, 2022
There was a problem hiding this comment.
When I tried to test this, I got these conflicting dep errors:
▶ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @storybook/addon-svelte-csf@2.0.10
npm ERR! Found: @storybook/svelte@7.0.0-beta.6
npm ERR! node_modules/@storybook/svelte
npm ERR! dev @storybook/svelte@"7.0.0-beta.6" from the root project
npm ERR! @storybook/svelte@"7.0.0-beta.6" from @storybook/sveltekit@7.0.0-beta.6
npm ERR! node_modules/@storybook/sveltekit
npm ERR! dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! 1 more (@storybook/svelte-vite)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/svelte@">=6.4.20" from @storybook/addon-svelte-csf@2.0.10
npm ERR! node_modules/@storybook/addon-svelte-csf
npm ERR! peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/sveltekit@7.0.0-beta.6
npm ERR! node_modules/@storybook/sveltekit
npm ERR! dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! @storybook/addon-svelte-csf@"^2.0.0" from @storybook/svelte-vite@7.0.0-beta.6
npm ERR! node_modules/@storybook/svelte-vite
npm ERR! @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/sveltekit@7.0.0-beta.6
npm ERR! node_modules/@storybook/sveltekit
npm ERR! dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @storybook/svelte@6.5.14
npm ERR! node_modules/@storybook/svelte
npm ERR! peer @storybook/svelte@">=6.4.20" from @storybook/addon-svelte-csf@2.0.10
npm ERR! node_modules/@storybook/addon-svelte-csf
npm ERR! peerOptional @storybook/addon-svelte-csf@"^2.0.0" from @storybook/sveltekit@7.0.0-beta.6
npm ERR! node_modules/@storybook/sveltekit
npm ERR! dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR! @storybook/addon-svelte-csf@"^2.0.0" from @storybook/svelte-vite@7.0.0-beta.6
npm ERR! node_modules/@storybook/svelte-vite
npm ERR! @storybook/svelte-vite@"7.0.0-beta.6" from @storybook/sveltekit@7.0.0-beta.6
npm ERR! node_modules/@storybook/sveltekit
npm ERR! dev @storybook/sveltekit@"7.0.0-beta.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/adambarrett/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/adambarrett/.npm/_logs/2022-12-14T15_53_26_834Z-debug-0.log
Do we need to do something here? Other than --force or --legacy-peer-deps I mean?
BigAB
approved these changes
Dec 14, 2022
Contributor
Author
I believe there is a way to fix it let me find out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary of change
Checklist