sum() method for Duration class#1177
Open
d-morrison wants to merge 2 commits intotidyverse:mainfrom
Open
Conversation
Member
|
This is really nice addition but I would prefer to avoid adding extra dependency just for this change. It's straightforward to do in plain R. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: #902
I'm trying to preserve the
Durationclass throughsum(); for example:Before:
After:
Created on 2025-01-15 with reprex v2.1.1
Not sure if this will be helpful, but figured it was worth trying; glad to keep working on a better solution based on your feedback.
I used
purrr::reduce(), which I'm guessing introduces an unwanted dependency.I tried
base::Reduce()but it doesn't preserves theDurationclass unfortunately.