Skip to content

Fix typo in UFW firewall rules#56

Merged
xmb9 merged 1 commit intotitaniumnetwork-dev:masterfrom
nota9x:patch-1
Mar 31, 2026
Merged

Fix typo in UFW firewall rules#56
xmb9 merged 1 commit intotitaniumnetwork-dev:masterfrom
nota9x:patch-1

Conversation

@nota9x
Copy link
Copy Markdown
Contributor

@nota9x nota9x commented Mar 12, 2026

Replace 'allow 5' with 'allow 53' in UFW rules for VPN setup.

Replace 'allow 5' with 'allow 53' in UFW rules for VPN setup.
Copilot AI review requested due to automatic review settings March 12, 2026 14:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the VPN setup guide’s firewall instructions to correctly open DNS (port 53) instead of an incorrect port, aligning the documented firewall rules with the listed required forwarded ports.

Changes:

  • Fixes UFW command to allow DNS traffic on port 53 (was incorrectly 5).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

sudo ufw allow OpenSSH
sudo ufw allow 500,4500/udp
sudo ufw allow 5
sudo ufw allow 53
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo ufw allow 53 opens DNS (TCP+UDP) to the public internet from any source. If the intent is only to let VPN clients resolve DNS through the tunnel, it’s safer to restrict this rule to the VPN client subnet/interface (e.g., 10.10.10.0/24) and/or specify the exact protocol(s) needed (53/udp and only add 53/tcp if required) to avoid accidentally creating an open resolver/amplification surface.

Suggested change
sudo ufw allow 53
sudo ufw allow from 10.10.10.0/24 to any port 53 proto udp
Copilot uses AI. Check for mistakes.
@xmb9
Copy link
Copy Markdown
Member

xmb9 commented Mar 31, 2026

Who the fuck asked for that clankers opinion

@xmb9 xmb9 merged commit a13d1f7 into titaniumnetwork-dev:master Mar 31, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants