Do not mangle a URL dependency as a factor-conditional - #353
Merged
gaborbernat merged 1 commit intoJul 26, 2026
Conversation
gaborbernat
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352.
Problem
tox-ini-fmtmangles a URL dependency, breaking thetox.ini:is reformatted to
https: //releases.wagtail.org/...— the injected space breaks the link and tox fails.Cause
CONDITIONAL_MARKER((?P<envs>[a-zA-Z0-9, ]+):(?P<value>.*)) recognises factor-conditional deps likepy311: pytest. A URL scheme (https) is all alphanumerics followed by:, sohttps://...matches withenvs="https",value="//...", and is re-emitted asf"{k}: {d}"→https: //....Fix
Add a
(?!//)negative lookahead after the colon, so ascheme://URL is never treated as a factor marker. A real factor-conditional never has//immediately after its colon, so behaviour for conditionals is unchanged. (git+https://was already safe — the+isn't in theenvscharacter class.)Added
test_deps_url_not_split_as_conditional; the full suite (95 passed, 1 skipped) andruff check/ruff format --checkstay green.