Skip to content

Colors rewrite#30622

Merged
MartijnCuppens merged 4 commits intomainfrom
master-mc-colors
Oct 13, 2020
Merged

Colors rewrite#30622
MartijnCuppens merged 4 commits intomainfrom
master-mc-colors

Conversation

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Apr 20, 2020

Purpose of this PR is to use a uniform approach on using colors:

@ffoodd
Copy link
Member

ffoodd commented Apr 21, 2020

I really prefer the percentage values you're suggesting to remove $theme-color-interval, it's much clearer!

@mdo
Copy link
Member

mdo commented Sep 16, 2020

Is this safe to bring back and set to ready for review for Alpha 3?

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Sep 23, 2020

Yeah, fine by me. Worked a bit on this today, but it seemed to be a bit more complex than I initially thought. I'll keep you posted.

Edit: It's done ;)

@MartijnCuppens MartijnCuppens marked this pull request as ready for review September 28, 2020 18:15
@MartijnCuppens MartijnCuppens requested a review from a team as a code owner September 28, 2020 18:15
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really helpful changes!

@XhmikosR XhmikosR requested a review from mdo October 12, 2020 12:21
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah, huge refactor and update, @MartijnCuppens! :shipit:

@MartijnCuppens MartijnCuppens merged commit cdc1216 into main Oct 13, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-colors branch October 13, 2020 07:58
@coliff coliff mentioned this pull request Nov 11, 2020
@stof
Copy link
Contributor

stof commented Nov 24, 2020

Any reason to implement this change using black and white (essentially working in HWB) rather than using Sass's scale-color($color, $lightness: 12%) ?

@miken32
Copy link

miken32 commented Apr 8, 2021

A little more guidance in the migration documentation would be helpful when 5.0 is released. Through some experimentation I found that shift-color($color, $level * 8) is similar to color-level($color, $level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment