feat(ui): run post-flush command without an output file - #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onow runs--post-flush-commandwhen no output file is set, so a single config line gives an in-session copy of the annotations:post-flush-command = pbcopythat works in every session, including a bare
revdiff HEAD~1, with no per-launch flags and no output file.the
-orequirement was never a design decision. #277 added the hook coupled to--output, and its author said in that thread that running it standalone made sense as a follow-up but would have grown the diff. Nothing validated the coupling, it was just the early return at the top ofhandleFlushOutput.behavior now, by what is configured:
WriteFilereturned, so the file and the command cannot driftan empty store is checked before any of that, so
Owith no annotations still says so rather than running a command with nothing to send. Tests cover all four modes plus hook-only success and failure.docs updated in step: the flag description no longer claims it requires
-o, and README,site/docs.html, the Claude and Codex reference pages, the Pi skill note,docs/ARCHITECTURE.mdand the gotchas entry all say what the flag actually does now. README also gains thepbcopyrecipe, which was the thing #336 could not find, withxclip -selection clipboardfor X11 andwl-copyfor Wayland, and OSC 52 kept as the answer for ssh and multiplexers.docs/backlog/post-flush-clipboard-route-undocumented.mdis deleted here, since this is the change that documents the route.Related to #336. Follow-up to #277.