fix: restore changelist action state after navigation - #2236
Open
ahivert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After running a changelist action with a confirmation page, such as Delete selected, navigating back restores
the native action select value but not Unfold’s Alpine action state. Consequently, x-show="action" remains
false and the Run button disappears.
This change synchronizes Alpine state with the select value during initialization and on pageshow, covering
browser back/BFCache restoration.
A regression test verifies the required Alpine bindings. No existing issue or PR covering this exact navigation
case was found.
Test plan
run_button_absent.mp4
run_button_fixed.mp4
Use of AI
All changes have been done by AI