CLDR-17570 Exclude rational formats from some checks #4530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
previously approved these changes
Mar 26, 2025
srl295
previously approved these changes
Mar 26, 2025
Comment on lines
+20
to
+23
| providers.add( | ||
| FixedCandidateProvider.forXPath( | ||
| "//ldml/numbers/rationalFormats/rationalUsage", | ||
| List.of("never", "sometimes"))); |
Member
There was a problem hiding this comment.
Sorry, maybe it was perfect but not good!
Member
There was a problem hiding this comment.
- you don't need to be in the survey tool. you could augment the unit test
TestFixedCandidate.testDefaultCandidates()with a specific case. That's why this is split out from the ST code.
Maybe something like this?
Suggested change
| providers.add( | |
| FixedCandidateProvider.forXPath( | |
| "//ldml/numbers/rationalFormats/rationalUsage", | |
| List.of("never", "sometimes"))); | |
| providers.add( | |
| FixedCandidateProvider.forXPathPattern( | |
| "//ldml/numbers/rationalFormats(?:\[@numberingSystem=[^]]*\])?/rationalUsage", | |
| List.of("never", "sometimes"))); |
Member
Author
There was a problem hiding this comment.
Dooh. Thanks.
@pedberg-icu I'm looking forward to getting rid of the numbers system less paths. Too easy to stumble with those.
Member
Author
|
Just fixed test failure |
Member
Author
|
Can someone rubberstamp this, so I can merge? Steven approved, and there was just a small fix for a test failure afterwards. |
srl295
approved these changes
Mar 26, 2025
macchiati
deleted the
CLDR-17570-Exclude-rational-formats-from-some-checks
branch
Member
Author
|
How can I fix it? I can't debug the survey tool. |
Member
If you can ever get Docker and or Mysql installed locally, you too could debug the survey tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17570
ALLOW_MANY_COMMITS=true