Skip to content

Conversation

@mk0walsk
Copy link
Contributor

@mk0walsk mk0walsk commented Dec 8, 2025

The local hook was pinned to ruff 0.6.9 while the pre-commit hook uses v0.14.7. This updates the local hook to match.

Tested both versions on the codebase - formatting output is nearly identical (1 char difference in _utils.py, minor
spacing adjustments). The custom enforce_kwargs_spacing.py ensures project style is preserved regardless.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mk0walsk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on synchronizing the ruff linter version within the project's pre-commit configuration. By aligning the local hook's ruff version with the one used by the main pre-commit hook, the PR aims to establish a consistent code quality standard and prevent potential formatting or linting conflicts that could arise from differing tool versions.

Highlights

  • Ruff Version Alignment: The ruff linter version in the local pre-commit configuration has been updated from 0.6.9 to 0.14.7 to ensure it matches the version used by the main pre-commit hook.
  • Consistency in Linting: This change ensures that local linting checks are consistent with the project's standard, minimizing discrepancies in formatting and style across different development environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of ruff in the .pre-commit-config.yaml file. The change bumps the version from 0.6.9 to 0.14.7 for the local ruff-format hook. The goal is to align dependency versions, which is a good practice for maintaining a consistent development environment. The change is straightforward and looks correct. I have no concerns with this update.

@danielhanchen
Copy link
Contributor

Oh thanks but sorry but might this clash with our precommit which is already in place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants