LSP support #38
Merged
LSP support #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Language Server Protocol (LSP) support to the DATEX JavaScript runtime, enabling IDE features like autocompletion and diagnostics for DATEX scripts. It works in conjunction with the datex-core LSP implementation referenced in PR #505.
Key Changes:
- Added LSP server infrastructure with bidirectional communication between Rust (WASM) and JavaScript
- Implemented async I/O adapters (Reader/Writer) for LSP message handling
- Added initial test coverage for basic LSP initialization
- Updated dependencies to support LSP functionality
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/lsp/BasicConnect.test.ts | New test validating basic LSP initialization flow with JSON-RPC messages |
| src/runtime/runtime.ts | Added startLSP method to Runtime class for starting LSP server with callback-based communication |
| src/datex-core/datex_core_js.d.ts | Updated TypeScript definitions with start_lsp method and reorganized interface definitions |
| scripts/build-npm.ts | Updated import to use simplified path for @std/fs/walk |
| rs-lib/src/runtime.rs | Added conditional LSP support with feature flag, cleaned up imports, improved crypto API usage |
| rs-lib/src/lsp/mod.rs | New module implementing LSP message routing between JavaScript and Rust using channels |
| rs-lib/src/lsp/io.rs | New async I/O adapters (Reader/Writer) implementing futures traits for LSP communication |
| rs-lib/src/lib.rs | Added conditional LSP module import with feature flag |
| rs-lib/src/crypto/crypto_js.rs | Refactored to remove unnecessary borrows and improve API usage |
| rs-lib/Cargo.toml | Added LSP dependencies and feature flag, updated URL crate version, added lsp_wasm feature |
| deno.lock | Updated lock file with new @std/fs dependency version |
| deno.json | Added @std/fs import mapping |
| Cargo.lock | Added LSP-related dependencies (lsp-types, realhydroper-lsp, tower, tracing, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benStre
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LSP support for JS combined with unyt-org/datex-core#505