ci: add checksum and signing support for release binaries#497
Open
vinayakjeet wants to merge 1 commit intourunc-dev:mainfrom
Open
ci: add checksum and signing support for release binaries#497vinayakjeet wants to merge 1 commit intourunc-dev:mainfrom
vinayakjeet wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc canceled.
|
vinayakjeet
force-pushed
the
ci/checksum-and-signing
branch
from
8e0b067 to
1458aa4
Compare
Contributor
|
Hello @vinayakjeet , thank you for this PR, but why are you removing the S3 upload, it is used for a completely different purpose. |
vinayakjeet
force-pushed
the
ci/checksum-and-signing
branch
from
1458aa4 to
57f1ae5
Compare
Contributor
Author
|
@cmainas Apologies for the confusion — I misread the scope and incorrectly removed the S3 upload. I've reverted that, the PR now only adds SHA256 checksums and cosign signing to release-trigger.yaml, leaving the S3 pipeline untouched. Ready for review .Thanks |
Add SHA256 checksum generation and cosign keyless signing to release-trigger.yaml. Checksums and signatures are generated at release time only, keeping the build pipeline fast and release artifacts verifiable. - Generate .sha256 checksum files for all release binaries - Sign binaries with cosign using GitHub OIDC (keyless) - Include .sha256, .sig, and .crt files in GitHub Releases Resolves: urunc-dev#199 Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com>
Contributor
|
@ananos please take a look since you have much more experience with cosign |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #199
Description
Add SHA256 checksum generation and cosign keyless signing to the release pipeline.
This generates
.sha256,.sig, and.crtfiles for all release binaries only during releases, attaches them to GitHub Releases for verifiable artifacts, and removes legacy S3 upload workflows to keep daily CI fast.Related issues
How was this tested?
LLM usage
None
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).